clang-tidy performance-unnecessary-value-param on gui.

diff --git a/gui/gpx.cc b/gui/gpx.cc
index afc2d6fdd11a04f5dd08762ec4bee231193b09c5..9a4e56d4088515a3f5c4dda6cd578e6c8332d5c9 100644 (file)
--- a/gui/gpx.cc
+++ b/gui/gpx.cc
@@ -29,7 +29,7 @@
 #include "gpx.h"
 
 
-static QDateTime decodeDateTime(const QString s)
+static QDateTime decodeDateTime(const QString& s)
 {
   QDateTime utc = QDateTime::fromString(s, "yyyy-MM-dd'T'HH:mm:ss'Z'");
   return utc;

diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index 47275a6a21e63c86218cf4bfc856c0ee4dee7bdd..552ba624763707b3e7d37a702011da8b40ae3faa 100644 (file)
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -1316,7 +1316,7 @@ void MainWindow::getWidgetValues()
 // It's also kind of dumb to return the name which SetCombo then looks up,
 // but there's not a 1:1 correlation between offsets in the combo box and
 // in the list of formats.
-QString MainWindow::getFormatNameForExtension(QString ext)
+QString MainWindow::getFormatNameForExtension(const QString& ext)
 {
   for (int i = 0; i < formatList_.size(); i++) {
     QStringList extensions = formatList_[i].getExtensions();

diff --git a/gui/mainwindow.h b/gui/mainwindow.h
index 88fc9cb876a8d5ebdd43aad081540a9f7db7d229..31d5399271686ab76b900b842884fbb700d80427 100644 (file)
--- a/gui/mainwindow.h
+++ b/gui/mainwindow.h
@@ -97,7 +97,7 @@ private:
   UpgradeCheck* upgrade;
   bool allowBetaUpgrades();
   void osLoadDeviceNameCombos(QComboBox*);
-  QString getFormatNameForExtension(QString ext);
+  QString getFormatNameForExtension(const QString& ext);
 
 protected:
   void closeEvent(QCloseEvent*);

diff --git a/gui/map.cc b/gui/map.cc
index f65af3d8b297d9c56eb35f47c41fb4f7b95adc51..d4282274f01122cef79df46b513e860b15ddad96 100644 (file)
--- a/gui/map.cc
+++ b/gui/map.cc
@@ -48,7 +48,7 @@ using std::string;
 using std::vector;
 
 //------------------------------------------------------------------------
-static QString stripDoubleQuotes(const QString s)
+static QString stripDoubleQuotes(const QString& s)
 {
   QString out;
   foreach (QChar c, s) {